Update and fix iocStats#199
Merged
AlexanderWells-diamond merged 3 commits intoDiamondLightSource:masterfrom Jan 12, 2026
Merged
Update and fix iocStats#199AlexanderWells-diamond merged 3 commits intoDiamondLightSource:masterfrom
AlexanderWells-diamond merged 3 commits intoDiamondLightSource:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #199 +/- ##
=======================================
Coverage 88.16% 88.16%
=======================================
Files 15 15
Lines 1259 1259
=======================================
Hits 1110 1110
Misses 149 149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The |
AlexanderWells-diamond
approved these changes
Jan 12, 2026
Collaborator
There was a problem hiding this comment.
Thank you Michael, I agree with these changes. The CI failures are indeed unrelated to this change.
I'm working on the CI fixes in PR #198
102800c
into
DiamondLightSource:master
41 of 43 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the bundled iocStats. Also, fix source dist builds by including
os/posix/*headers.